Fix of the sign convention of rotation matrices #172

cborschensky · 2024-11-06T09:53:51Z

Fixes #169. The mismatch between conventions of rotation matrices is resolved by enforcing the parametrisation of arXiv:2007.02985, Eqs. (5) ff.

We implement a new function AdjustRotationMatrix() which calculates the rotation matrix in the parametrisation of the given paper and ensures that the rotation angles are within $-\frac{\pi}{2}$ and $+\frac{\pi}{2}$. This new rotation matrix, saved in the vector HiggsRotationMatrixEnsuredConvention, is then used for the calculation inside TripleHiggsCouplings(). The convention for the rotation matrices and angles as calculated by BSMPT now also agrees with the one used in the ScannerS code.

Additionally, the indices for the mass eigenstates in the rotation matrix are now computed just once for all implemented models inside the respective AdjustRotationMatrix() function (previously, the indices were computed separately in the write() and TripleHiggsCouplings() functions).

General structure of the changes and implementation for the R2HDM by @lisabiermann.

…t naming

…trix()

… HiggsRotationMatrixEnsuredConvention vector

…matrices where only massless Goldstones should be (which can happen for a faulty parameter point with a negative mass)

vollous · 2024-11-06T11:02:29Z

Can you make this PR to the "develop" branch?

cborschensky · 2024-11-06T11:07:48Z

Can you make this PR to the "develop" branch?

Done!

…er#176) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.4 to 4.6.9. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.4...v4.6.9) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

include/BSMPT/models/ClassPotentialOrigin.h

vollous

These changes broke two unit tests:

17 - Checking triple higgs NLO couplings in the C2HDM (Failed)
43 - Checking triple higgs NLO couplings in the CPINTHEDARK (Failed)

Please check what is happening.

This fix probably comes from some mistake BSMPT was making, can you add a unit test for that specific mistake, so that we prevent it in the future.

vollous · 2024-12-03T09:24:10Z

include/BSMPT/models/ClassPotentialC2HDM.h

@@ -98,6 +98,10 @@ class Class_Potential_C2HDM : public Class_Potential_Origin
  double CTempC1 = 0, CTempC2 = 0, CTempCS = 0;
  double R_Hh_1 = 0, R_Hh_2 = 0, R_Hh_3 = 0, R_Hl_1 = 0, R_Hl_2 = 0, R_Hl_3 = 0,
         R_Hsm_1 = 0, R_Hsm_2 = 0, R_Hsm_3 = 0;
+
+  int pos_G0, pos_G1, pos_G2, pos_H1, pos_H2, pos_h1, pos_h2, pos_h3;


Using the sufixes 1 as + and 2 as - might be a bit confusing, particular when h1exists.
Could we use

G1 = Gp
G2 = Gm
H1 = Hp
H2 = Hm

instead?

vollous · 2024-12-03T09:24:30Z

include/BSMPT/models/ClassPotentialN2HDM.h

@@ -99,6 +99,10 @@ class Class_Potential_N2HDM : public Class_Potential_Origin
  double NDus = 0, NDL6 = 0, NDL7 = 0, NDL8 = 0, NDvs = 0, NDTS = 0;
  double DTCharged = 0;

+  int pos_G0, pos_G1, pos_G2, pos_H1, pos_H2;


Using the sufixes 1 as + and 2 as - might be a bit confusing, particular when h1exists.
Could we use

G1 = Gp
G2 = Gm
H1 = Hp
H2 = Hm

instead?

vollous · 2024-12-03T09:24:37Z

include/BSMPT/models/ClassPotentialR2HDM.h

@@ -90,6 +90,9 @@ class Class_Potential_R2HDM : public Class_Potential_Origin
  int Type       = 0;
  double CTempC1 = 0, CTempC2 = 0, CTempCS = 0;

+  int pos_G1, pos_G2, pos_H1, pos_H2, pos_G0, pos_A, pos_H, pos_h;


Using the sufixes 1 as + and 2 as - might be a bit confusing, particular when h1exists.
Could we use

G1 = Gp
G2 = Gm
H1 = Hp
H2 = Hm

instead?

vollous · 2024-12-03T10:19:58Z

src/models/ClassPotentialC2HDM.cpp

-      NeutralHiggs[i] = HiggsMasses[posN.at(i)];
+      int ii = int(i);
+      int jj = int(j);
+      if (not((jj == pos_rho1  and (ii == pos_G1 or ii == pos_H1)) or


This piece of code is a bit confusing, what is it checking for? Can you refactor it a little bit?

vollous · 2024-12-03T10:33:15Z

src/models/ClassPotentialC2HDM.cpp

-      MhDown = std::sqrt(NeutralHiggs[0]);
+      int ii = int(i);
+      int jj = int(j);
+      if (not((jj == pos_si_rho1 and (ii == pos_si_G1 or ii == pos_si_H1)) or


What is it checking for? Can you refactor it a little bit?

vollous · 2024-12-03T10:38:17Z

src/models/ClassPotentialCxSM.cpp

+    {
+      int ii = int(i);
+      int jj = int(j);
+      if (not((jj == pos_Gp    and ii == pos_Gp) or


This piece of code is a bit confusing, what is it checking for? Can you refactor it a little bit?

vollous · 2024-12-03T10:45:56Z

src/models/ClassPotentialN2HDM.cpp

-      countposN++;
+      int ii = int(i);
+      int jj = int(j);
+      if (not((jj == pos_rho1  and (ii == pos_G1 or ii == pos_H1)) or


This piece of code is a bit confusing, what is it checking for? Can you refactor it a little bit?

src/models/ClassPotentialOrigin.cpp

vollous · 2024-12-03T10:54:38Z

src/models/ClassPotentialOrigin.cpp

+    {
+      if (!almost_the_same(inv(i, j), transp(i, j), precision))
+      {
+        InvEqTrans = false;


Some minor improvements here. If we reach this spot we can return false right away without having to check for all other matrix elements.

vollous · 2024-12-03T10:59:19Z

src/models/ClassPotentialR2HDM.cpp

-      HiggsRot(i, j) = HiggsRotationMatrix[i][j];
+      int ii = int(i);
+      int jj = int(j);
+      if (not((jj == pos_rho1 and (ii == pos_G1 or ii == pos_H1)) or


This piece of code is a bit confusing, what is it checking for? Can you refactor it a little bit?

lisabiermann · 2024-12-05T16:42:26Z

These changes broke two unit tests:
* 17 - Checking triple higgs NLO couplings in the C2HDM (Failed)

* 43 - Checking triple higgs NLO couplings in the CPINTHEDARK (Failed)
Please check what is happening.

This fix probably comes from some mistake BSMPT was making, can you add a unit test for that specific mistake, so that we prevent it in the future.

This was expected. We have to re-generate the unit test sources with the corrected trilinear couplings.

* Combine linters * Add whitelines to trigger formatting * Automatically applied linter * add linter PAT * Automatically applied linter * Remove new lines * rename linter job --------- Co-authored-by: GitHub Actions Bot <>

Borschensky Christoph and others added 11 commits October 28, 2024 20:19

Trilinear sign fix for C2HDM, WIP

50c1f88

Sign fix for rotation matrices for all currently implemented models

904c0e1

Renamed variable CalcCouplingsdone to CalcCouplingsDone for consisten…

447a15b

…t naming

Fixed some comments in AdjustMixingMatrix() of the C2HDM

a912bc5

Fixed variable names for mass/gauge state indices in AdjustRotationMa…

5004581

…trix()

Added empty AdjustRotationMatrix() to standalone/GenericModel.cpp

322549c

Modified CheckRotationMatrix() to allow for det=+1 or -1; initialised…

4d24c93

… HiggsRotationMatrixEnsuredConvention vector

Calculate mass indices only once, WIP

cc1db38

Mass index determination for N2HDM in AdjustRotationMatrix()

a81ffaf

Do the index calculation just once for all implemented models

720373f

Added a check in case a non-Goldstone appears in a row of the mixing …

1ef271e

…matrices where only massless Goldstones should be (which can happen for a faulty parameter point with a negative mass)

cborschensky requested review from phbasler, lisabiermann, JonasMueller1991 and vollous as code owners November 6, 2024 09:53

cborschensky changed the base branch from master to develop November 6, 2024 11:07

lisabiermann added the bug Something isn't working label Nov 6, 2024

dependabot bot and others added 3 commits November 14, 2024 08:41

Merge branch 'phbasler:master' into trilinear_sign_fix

b8e54b5

vollous reviewed Nov 29, 2024

View reviewed changes

include/BSMPT/models/ClassPotentialOrigin.h Outdated Show resolved Hide resolved

vollous requested changes Dec 3, 2024

View reviewed changes

phbasler and others added 3 commits December 9, 2024 10:04

Combine cmake and c++ linter in one job (phbasler#185)

8e69431

* Combine linters * Add whitelines to trigger formatting * Automatically applied linter * add linter PAT * Automatically applied linter * Remove new lines * rename linter job --------- Co-authored-by: GitHub Actions Bot <>

Moved all almost_the_same functions to utility.cpp/.h

25acde2

Merge branch 'phbasler:master' into trilinear_sign_fix

b53eea1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix of the sign convention of rotation matrices #172

Fix of the sign convention of rotation matrices #172

cborschensky commented Nov 6, 2024

vollous commented Nov 6, 2024

cborschensky commented Nov 6, 2024

vollous left a comment

vollous Dec 3, 2024

vollous Dec 3, 2024

vollous Dec 3, 2024

vollous Dec 3, 2024

vollous Dec 3, 2024

vollous Dec 3, 2024

vollous Dec 3, 2024

vollous Dec 3, 2024

vollous Dec 3, 2024

lisabiermann commented Dec 5, 2024

Fix of the sign convention of rotation matrices #172

Are you sure you want to change the base?

Fix of the sign convention of rotation matrices #172

Conversation

cborschensky commented Nov 6, 2024

vollous commented Nov 6, 2024

cborschensky commented Nov 6, 2024

vollous left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lisabiermann commented Dec 5, 2024